OFL-1.1 optionally templated #491
Conversation
Fixes spdx#451 See https://opensource.org/licenses/OFL-1.1 and instructions at http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL#83afb016 and many in the wild at https://github.com/search?q=license%3Aofl-1.1
There was a problem hiding this comment.
I'm in favor of these additions (after a few minor tweaks mentioned in inline comments). But:
-
Upstream has multiple “Copyright (c) …” paragraphs, as they try and show how the copyright paragraphs will apply to a renamed font with multiple authors. We could maybe cover that generically with a complicated
<alt>regexp, but we still have to pick what to use as the canonical text. I think the SPDX policy is to use the upstream text verbatim, even if that doesn't apply cleanly to folks creating a new OFL-1.1 project (who will only need a single “Copyright (c) …” paragraph. But I'm not a maintainer ;). -
OFL-1.1 standard license header #451 is about us not declaring a
standardLicenseHeaderfor the OFL-1.1. This PR doesn't address that. I'm fine punting it to future work, but I don't think we want “Fixes OFL-1.1 standard license header #451” in the original post.
src/OFL-1.1.xml
Outdated
| @@ -6,6 +6,11 @@ | |||
| <crossRef>http://www.opensource.org/licenses/OFL-1.1</crossRef> | |||
| </crossRefs> | |||
| <notes>This license was released: 26 February 2007.</notes> | |||
| <optional> | |||
There was a problem hiding this comment.
copyrightText is already optional (guideline 10.1.1). I'm in favor of explicit <optional> tags for optional copyright text, but that's not where this repo is now. I think we should shift this line after <copyrightText> for this PR and move it back to here it if/when the whole repository moves to use explicit <optional> tags for <copyrightText>.
There was a problem hiding this comment.
Thanks, agreed on all points.
src/OFL-1.1.xml
Outdated
| <optional> | ||
| <copyrightText><p>Copyright (c) <dates>, <Copyright Holder> (<URL|email>), | ||
| <br/>with Reserved Font Name <Reserved Font Name>.</p></copyrightText> | ||
| <p>This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: http://scripts.sil.org/OFL</p> |
There was a problem hiding this comment.
The “This license is copied below…” bit is a separate paragraph upstream.
|
OK, I removed 'fixes'. |
See previous discussion at #451
See https://opensource.org/licenses/OFL-1.1 and instructions at http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL#83afb016 and many in the wild at https://github.com/search?q=license%3Aofl-1.1