-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run spdk/autorun_post on common tests artifacts #24
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,13 +19,14 @@ on: | |
type: string | ||
default: '' | ||
|
||
env: | ||
spdk_path: './spdk' | ||
jobs: | ||
checkout_spdk: | ||
runs-on: ubuntu-latest | ||
env: | ||
is_called: ${{ inputs.client_payload != '' && fromJson(inputs.client_payload) != '' || false }} | ||
gerrit_ref: ${{ inputs.gerrit_ref }} | ||
spdk_path: './spdk' | ||
steps: | ||
# Required to use locally defined actions | ||
- name: Checkout the spdk-ci repo locally | ||
|
@@ -49,6 +50,54 @@ jobs: | |
needs: checkout_spdk | ||
uses: ./.github/workflows/per_patch.yml | ||
|
||
summary: | ||
# 22.04 used on purpose; it has lcov+gcov versions that are compatible with what | ||
# is used in cijoe's Fedora 40 images. Using lcov+gcov from ubuntu-latest results | ||
# in warnings and/or failures. | ||
runs-on: ubuntu-22.04 | ||
needs: | ||
- tests | ||
steps: | ||
- name: Download the SPDK repository | ||
uses: actions/[email protected] | ||
with: | ||
name: repository | ||
path: ${{ github.workspace }}/spdk | ||
|
||
- name: Download artifact tarballs | ||
uses: actions/[email protected] | ||
with: | ||
pattern: 'autorun_*_artifacts' | ||
|
||
- name: Show artifacts | ||
run: | | ||
tar xf ${{ env.spdk_path }}/repository.tar.gz -C ${{ env.spdk_path }} | ||
|
||
# TODO: either use an official lcov image or create our own | ||
# TODO: get rid of pandas dependency in spdk/autorun_post.py. | ||
# It's ~1GB with all it's dependecies, which is an overkill for | ||
# a few table operations. | ||
sudo apt-get update && sudo apt-get install -y lcov python3-pandas | ||
|
||
# Favourite part <3 | ||
# lcov when registers /opt/spdk/** paths for files when running in Qemu | ||
# spawned by cijoe. But the working directory and paths are different | ||
# in this step so need to replace them. | ||
# TODO: This should be an option in autorun_post.py script itself. | ||
sed -i -e "s#^SF:/[^/]*/spdk/#SF:$PWD/spdk/#" */cov_total.info | ||
|
||
spdk/autorun_post.py -s -d ./ -r ./spdk | ||
|
||
- name: Upload artifacts | ||
uses: actions/[email protected] | ||
with: | ||
name: _autorun_summary_output | ||
path: | | ||
doc | ||
coverage | ||
ut_coverage | ||
post_process | ||
|
||
report: | ||
# Only run if it was triggered by Gerrit event, with JSON for it | ||
if: ${{ needs.checkout_spdk.outputs.is_called == 'true' }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine to me for now, but in the end we should use the container image used for testing (#26).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definietly!