Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixing nvmf-tcp-vm-autotest by adding missing xxd #23

Closed
wants to merge 1 commit into from

Conversation

glimchb
Copy link
Contributor

@glimchb glimchb commented Feb 21, 2025

will be moved to pkgdep.sh or autotest_setup.sh after merging to spdk/spdk is re-enabled

see spdk/spdk#3615 (comment)

will be moved to `pkgdep.sh` or `autotest_setup.sh` after merging to spdk/spdk is re-enabled
@karlatec
Copy link
Contributor

Even if it's temporary - why put it here?
https://github.com/spdk/spdk-ci/actions/workflows/build_qcow2.yml takes Gerrit refspec as an input argument, so we can build a new image with xxd package included even without merging the change.

@glimchb
Copy link
Contributor Author

glimchb commented Feb 21, 2025

@karlatec because it is quicker and easier to move forward like this self contained
and then take all missing packages and add them to gerrit properly and review there

@karlatec
Copy link
Contributor

I still suggest closing this one.
I already have a change https://review.spdk.io/c/spdk/spdk/+/25661 adding xxd to list of installed pacakges.

Once @tomzawadzki merges #28 we can build the qcow2 image with xxd installed (which is what I did on my fork here)

@karlatec
Copy link
Contributor

New qcow2 image with xxd is here: https://github.com/spdk/spdk-ci/actions/runs/13562927805

@tomzawadzki
Copy link
Contributor

No longer needed, upstream SPDK now contains xxd - spdk/spdk@d0bb354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants