-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CODEOWNERS file #18
base: main
Are you sure you want to change the base?
Conversation
this helps to show who is reviewing code and mages notifications
@@ -0,0 +1 @@ | |||
* @karlatec @tomzawadzki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO Simon should be here as well
Typo "manages"? |
I'm not sure what purpose does it serve to specify CODEOWNERS at this time. Currently only SPDK Core Maintainers have the write permission on the repository (only those can be in CODEOWNERS). Neither Karol or Simon do at this time. Meanwhile this will be needed once more people are contributing, especially with workflows that they know best and/or own runners for them. Lets come back to this once the process for running the CI is much more clear and working. |
|
I would definitely want to be the ultimate decider to anything that's related to our self-hosted runner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this helps to show who is reviewing code and mages notifications