Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where dead state elimination leads to disconnected graphs #1873

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix a bug where dead state elimination leads to disconnected graphs #1873

merged 1 commit into from
Jan 15, 2025

Conversation

phschaad
Copy link
Collaborator

No description provided.

@phschaad phschaad requested a review from acalotoiu January 15, 2025 09:43
@phschaad phschaad added the bug Something isn't working label Jan 15, 2025
acalotoiu
acalotoiu approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - surprising that it was still a bug :)

@phschaad phschaad enabled auto-merge January 15, 2025 09:46
@phschaad phschaad added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 45b00ee Jan 15, 2025
9 checks passed
@phschaad phschaad deleted the users/phschaad/dead_state_elim_fix branch January 15, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acalotoiu acalotoiu acalotoiu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschaad @acalotoiu