Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes and QOL improvements #1853

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Jan 8, 2025

  • Allow the use of compression when using SDFG.view, allowing large SDFGs to be viewed
  • Fix codegen issues related to out-of-date CFG lists
  • Allow pass options to be passed to SDFG.simplify, passing them along to passes
  • Implement the pass options API for InlineSDFGs
  • Fix serialization issues for reduction library nodes where the identity function is np.inf or similar non-numeric numbers, which cause issues with other JSON deserializers that do not treat 'Infinity' (or similar) as a number.
  • Fix missing symbol arguments when parsing a nested SDFG which takes a structure argument where a member's size is defined by a symbol not explicitly passed to the NSDFG, using symbol mappings
  • Fix an error where the frontend reports missing symbols when a scalar struct member is being used in the range of a loop
  • Fix replacements for np.where when using a member of a structure

@phschaad phschaad requested review from tbennun and removed request for tbennun January 8, 2025 12:54
@phschaad phschaad requested a review from tbennun January 8, 2025 13:46
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved except for one question

dace/transformation/passes/fusion_inline.py Show resolved Hide resolved
@phschaad phschaad added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit df19e39 Jan 8, 2025
9 checks passed
@phschaad phschaad deleted the users/phschaad/various_fixes branch January 8, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants