Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address python frontend shape mismatch for indirect accesses in assignments #1831

Merged
merged 5 commits into from
Dec 21, 2024
Merged

Address python frontend shape mismatch for indirect accesses in assignments #1831

merged 5 commits into from
Dec 21, 2024

Conversation

phschaad
Copy link
Collaborator

No description provided.

@phschaad phschaad changed the title Add regression test Address python frontend shape mismatch for indirect accesses in assignments Dec 19, 2024
@tbennun tbennun marked this pull request as ready for review December 20, 2024 17:56
@tbennun tbennun enabled auto-merge December 20, 2024 22:24
@tbennun tbennun disabled auto-merge December 20, 2024 22:25
@tbennun
Copy link
Collaborator

tbennun commented Dec 20, 2024 •
edited
Loading

@phschaad I'd add, just to be safe, a similar test(s) where ind and/or B is multidimensional (and we access B[0, ind[1], 2:4] += ...). Thanks!

@tbennun tbennun enabled auto-merge December 21, 2024 02:44
@tbennun tbennun added this pull request to the merge queue Dec 21, 2024
Merged via the queue into main with commit aaba591 Dec 21, 2024
9 checks passed
@tbennun tbennun deleted the users/phschaad/frontend_slice_fix branch December 21, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschaad @tbennun