Remove the custom generic Gitleaks rule as it's not needed anymore #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added in #76 to detect "dev" and "prod" keys, but I've since started to use prefixed encryption keys in #269 so the custom rule is not needed anymore. This is why you use prefixed keys, it makes things simple, and I like making things simple. Also, the custom generic rule started throwing many false positives after I've upgraded to Gitleaks 8.23.1 for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added in #76 to detect "dev" and "prod" keys, but I've since started to use prefixed encryption keys in #269 so the custom rule is not needed anymore. This is why you use prefixed keys, it makes things simple, and I like making things simple.
Also, the custom generic rule started throwing many false positives after I've upgraded to Gitleaks 8.23.1 for some reason.