Drop Psalm baseline #457
Merged
Drop Psalm baseline #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other words, stop using the baseline.
Either the bug has been fixed in Psalm, or I have refactored my code.
`composer validate` now throws a general warning: "The version field is present, it is recommended to leave it out if the package is published on Packagist." Although the package is not published on Packagist, but here we are. Composer was throwing a different error before, and that's why the version number was added. Reverts commit a705191 #296
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
psalm-baseline.xmlby adding some checks, or asserts, or by refactoring the code.Also un-suppress some errors that are not reported anymore, and remove version number from
composer.jsonso thatcomposer validatedoesn't complain anymore.