Allow setting yamlInline for ObjectDriver #212
Conversation
| @@ -12,6 +12,11 @@ | |||
|
|
|||
| class ObjectDriver implements Driver | |||
| { | |||
| public function __construct( | |||
There was a problem hiding this comment.
Instead of this single parameter, let's allow passing an array with options.
The default options should be
'yaml_inline' => 2,
'yaml_indent' => 4,
'yaml_flags' => Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK,
Any options passed should be merged with the defaults.
There was a problem hiding this comment.
I also thought about it. fine with me.
However, I had a hard time, testing the indentation. The dedent function does behave, like I expected.
E.g. When setting the intent to 2 only the first line is corrected, but the others are still indented by 4 ?!
If you are fine to have a test for only the inline var, I can do it in my PR.
There was a problem hiding this comment.
If you are fine to have a test for only the inline var, I can do it in my PR.
That's ok!
There was a problem hiding this comment.
Cool! Requested changes are done!
…pdate serialization method to use it
|
The tests are failing, could you take a look? |
See issue #211