feat: implement a way of matching the fields to the jsonapi spec #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoolGoose
force-pushed
the
feat/json-api-matchin
branch
3 times, most recently
from
8b916fd to
774579c
Compare
CoolGoose
changed the title
|
I think it's ready for a review 😅 |
CoolGoose
force-pushed
the
feat/json-api-matchin
branch
from
774579c to
21de881
Compare
pedro0125
reviewed
Dec 5, 2024
CoolGoose
force-pushed
the
feat/json-api-matchin
branch
from
21de881 to
c869008
Compare
CoolGoose
force-pushed
the
feat/json-api-matchin
branch
from
c869008 to
beb5862
Compare
There was a problem hiding this comment.
Gonna remove this one after merging
There was a problem hiding this comment.
thank you for the review. As a curiosity @AlexVanderbist how does one run the tests ? I'm happy to have a separate PR for this if it helps, or at least learn how you guys run the tests internally.
|
Hey @CoolGoose, thank you for taking the time to make this more compatible with the base JSON API specification and Timacdonald's package. Although it adds some complexity, I'm happy to merge it since the tests are passing and no breaking changes have been introduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks, this is just a PoC (that I am cleaning up as we speak) of figuring out if there's interest on another config option to allow mapping closer to the JsonAPI spec and making this easier to use from the start with https://github.com/timacdonald/json-api