New Filter belongs to #975
Conversation
| return $relatedModel; | ||
| } | ||
|
|
||
| protected function getModelFromRelation(Model $model, string $relation, int $level = 0): ?Model |
There was a problem hiding this comment.
Is $level still being used? I can see it's passed on recursively but never used.
There was a problem hiding this comment.
As a habit, whenever I make a recursive function I send the level parameter, sometimes it is necessary to determine the first iteration of the rest. In this case it was not necessary and I forgot to delete it. You can delete it safely.
| { | ||
| public static function make($property): static | ||
| { | ||
| return new static("Filter property `{$property}` is invalid."); |
There was a problem hiding this comment.
Can we add a $reason to this exception? From the implementation I see there's only one reason this happens: belongs to relationship is not an Eloquent relationship.
There was a problem hiding this comment.
Exactly.
There was another exception that I wasn't handling (on purpose), when the relation (or the last relation in a nested dotted string) is not a BelongTo relation, in that case an unhandled exception was thrown but Laravel gave a correct message and context to find this error. This case was not covered in the tests.
Based on that exception, now remove InvalidFilterProperty and throw that same exception RelationNotFoundException. I also added more test cases that cover all the options (this case and the previous one).
This native Laravel exception gives a more specific message to fix the error.
There was a problem hiding this comment.
@AlexVanderbist Have you been able to review this?
There was a problem hiding this comment.
@freekmurze Have you been able to review this?
gpibarra
force-pushed
the
filterBelongsTo
branch
from
ff1034c to
4b3f57e
Compare
|
Thanks @AlexVanderbist! The documentation is pending. |
This new filter receives the id and allows to call the native method
whereBelongsTomethod of the model (doc).The method accepts nested relationships.
The filter accepts receiving an array with the ids.
Unfortunately my English is not good and I couldn't write the documentation correctly.
If you think the PR is correct, could you help me with the documentation?