Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio buttons with value 0 are incorrectly marked as checked #249

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Radio buttons with value 0 are incorrectly marked as checked #249

merged 3 commits into from
Feb 5, 2025

Conversation

acarpio89
Copy link
Contributor

There is an issue causing radio buttons with value 0 to be marked as checked.

When $this->old($name) is null and $value is 0, null == 0 evaluates true.

Using strict comparison fixes the issue.

@freekmurze freekmurze merged commit 248508f into spatie:main Feb 5, 2025
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acarpio89 @freekmurze