Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Configuration and Base Image #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arkaprovob
Copy link

Made several key improvements to our Docker setup to enhance performance, usability, and security:

  1. Dockerfile Refactoring:

    • The Dockerfile has been refactored to minimize the number of layers. This change will make the build process more efficient and reduce the overall image size.
  2. Editor and Utilities Update:

    • Added vim as the default editor for editing files inside the container. This will improve the user experience for developers who are accustomed to using vim.
    • Included coreutils to provide essential utilities such as ln and other basic commands. This ensures that our container has the necessary tools for fundamental operations.
  3. Base Image Update for Security:

    • The base image of the Docker container has been updated. This change addresses and mitigates known vulnerability issues, enhancing the security of our containerized application.

vim editor will be used for editing files inside the container and coreutils  added for ln and other basic utilities
@arkaprovob arkaprovob self-assigned this Oct 14, 2023
@arkaprovob arkaprovob added this to the 2.0.0 milestone Oct 14, 2023
@arkaprovob arkaprovob added enhancement New feature or request upgrade labels Oct 14, 2023
Copy link
Contributor

@kunyan kunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the core reason for this change are upgrade RHEL8 to RHEL9.
I'm OK with all the changes.

Just a small suggestion. we only need this image with a stable runtime
We should follow KISS principle

Forgive me don't know the other reasons for all of changes. please merge it if it needed

@@ -1,26 +1,24 @@
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.3-298.1618432845
FROM registry.access.redhat.com/ubi9:9.2-755
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no important dependency requirement, I still recommend use the UBI minimal image.

Name Size Uncompressed Size
ubi9 74.5 MB 206.9 MB
ubi9-minimal 36.1 MB 92.9 MB

Less size means less code and less security leak.
I think ubi8-mininal has been verified all features we need are supported.

PS: I have't check if there has any duplicate packages had been installed in ubi base image, but will install again along with httpd installation.

IMO, this is not a big problem, but we should choose the better one for our situation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about this ?
registry.access.redhat.com/ubi9/ubi-minimal:9.2-750.1696515534

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry.access.redhat.com/ubi9-minimal:9.2-750.1696515534

Dockerfile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants