Porting functionals for Windows EXPLICITLY BREAKING LINUX/MACOS #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to fix threading for windows. these are NOT integrated with the linux/mac_os yet as i wasnt focussed on that. this implements the windows API for threading
See previous Commit
accidentally cut them out in a copy-paste from another test branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At best a poor attempt to implement the functionality of TAP-B in windows. this code has been tested to work for windows, but given the alterations will break LINUX and MACOS functionals. ill let others to fix that portion as that was outside of scope.
this PR is mainly to allow others to also get functionals on windows machines, whilst hoping to later integrate it as standalone/full implementation that uses a switch to keep implementation of the original branch the same.
Essentially solves #26 but does so in a poor way