Skip to content

Commit

Permalink
Increase tooltip hover offset to avoid being obscured by mouse
Browse files Browse the repository at this point in the history
Fixes jlfwong#444

For context: the default cursor on Windows 10 is 16px wide. Most OSes allow you to make it much bigger so there's not necessarily a 'right' value here, but it feels sensible to at least avoid obscuring it when using defaults.

Given most cursors display _below_ the pixel at which the cursor is pointing, a solution which works in more cases would probably need to make a change from the current decision to `// Place the tooltip below the cursor` but for now I have avoided doing this (I'm not sure of the historical reasons) and instead done the minimal improvement.
  • Loading branch information
sparrowt authored Nov 14, 2023
1 parent de17f12 commit d5c0d6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/views/hovertip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function Hovertip(props: HovertipProps) {
const containerWidth = containerSize.x
const containerHeight = containerSize.y

const OFFSET_FROM_MOUSE = 7
const OFFSET_FROM_MOUSE = 20

const updateLocation = useCallback((el: HTMLDivElement | null) => {
if (!el) return
Expand Down

0 comments on commit d5c0d6a

Please sign in to comment.