Nokogiri::XML::Schema.read_memory() support keyword arguments #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your patience. The last couple of weeks have been really busy, but I'm hoping to review and merge this in the next week or so! |
and RelaxNG.read_memory is now forwarding to .new Also increase depth of test coverage for constructors taking both string and IO arguments
- document Schema.new as the primary constructor and Schema.read_memory is now forwarding to .new - correct the Schema.read_memory documentation which incorrectly said that IO was not supported. Also updated the tests to cover that input type. - add example for Schema.from_document
flavorjones
force-pushed
the
xml-schema-arg-forwarding
branch
from
1e2632e to
23735e9
Compare
|
Rebased and tidied docs in Schema and RelaxNG (because they're so similar and I wanted them to be documented similarly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Related to #3323, introducing keyword argument support in Nokogiri::XML::Schema.read_memory() and argument forwarding in Nokogiri::XML::Schema{,.new}().
Have you included adequate test coverage?
Some minor test coverage mimicking the existing permutations of options.
Does this change affect the behavior of either the C or the Java implementations?
No