ci: declare mutex_m in Gemfile; it's been removed from ruby 3.4 #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly because it's not in the cruby default gems anymore, but there isn't a jruby gem.
flavorjones
added a commit
that referenced
this pull request
Jun 14, 2024
**What problem is this PR intended to solve?** `mutex_m` is one of the gems that was dropped from the default gems in Ruby 3.4. I think we originally added it to the Gemfile in #3092 because minitest was using it, and that changed in minitest/minitest@5f5c2111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Ruby head builds fail because gem dependencies rely on mutex_m which has been removed from ruby head's default gems.
Let's add a section to the Gemfile for these (temporary) dependency declarations.
Also, remove the unnecessary dependency on NKF which has been removed from CRuby's default gems, but which doesn't have a JRuby gem (yet?).