fix(libxml): default Reader node encoding to UTF-8 #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
2891-reader-output-encoding
branch
from
d4a30b8 to
2c97b17
Compare
flavorjones
force-pushed
the
2891-reader-output-encoding
branch
3 times, most recently
from
045d4f4 to
35c8308
Compare
when it's not specified either as a method param or in the document Fixes #2891
flavorjones
force-pushed
the
2891-reader-output-encoding
branch
from
35c8308 to
26fcb96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
default Reader node encoding to UTF-8 when it's not specified either as a method param or in the document
Fixes #2891
Have you included adequate test coverage?
Yes, I've added coverage.
Does this change affect the behavior of either the C or the Java implementations?
Yes, this updates the C implementation but does not update the Java implementation because Reader encoding is already wonky there in a few edge cases.