Add support for go1.x lambda runtime #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komapa
commented
Mar 22, 2021
| @@ -28,11 +28,11 @@ def _lambda(*fn_args) | |||
| new_fn.properties.handler fn_handler | |||
| new_fn.properties.runtime lookup[:runtime] | |||
| new_fn.properties.function_name fn_function_name || fn_name | |||
| new_fn.properties.role fn_role | |||
There was a problem hiding this comment.
Moving this up so we can set the role even when the lambda function can't be inlined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks. We needed to have support for go1.x lambda functions in SparkleFormation and these were the fixes needed to have that possible. I tried to update the Changelog which show the best what was added and fixed.
Fixes #9