Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Unable to Destroy Create Failed Bucket #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

🐛 Unable to Destroy Create Failed Bucket #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# v0.0.2
* Fixes bug where a bucket in a failed state
(bucket was not created) exists in a stack
and this causes the callback to fail.

# v0.0.1
* Initial release
4 changes: 4 additions & 0 deletions lib/sfn-bucketpurge/bucket_purge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ def before_destroy(args)
rescue
next
end
if resource.name.nil?
ui.info "Found a failed resource, whose name is nil, skipping..."
next
end
next unless resource.is_a?(Miasma::Models::Storage::Bucket)
files = resource.files.all
next if files.empty?
Expand Down
2 changes: 1 addition & 1 deletion lib/sfn-bucketpurge/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module SfnBucketPurge
VERSION = Gem::Version.new('0.0.1')
VERSION = Gem::Version.new('0.0.2')
end