Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add tmp redirect for PR testing #51

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jonoliver
Copy link
Member

Description

[add description of work done here]

Spec

Designs: [link to design if applicable]

See Story: FSA21V2-__

To Test

  1. Make sure all PR Checks have passed (Github Actions, Netlify etc).
  2. Pull down all related branches.
  3. Confirm all tests pass: npm run test:ci
  4. [continue instructions here]

[For an example of good validation instructions, check out Bryan's Bouncy Ball PR.]

Validation

The following has been completed by the developer:

[delete anything irrelevant to this PR]

  • This PR has visual elements, so it was reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).
  • This PR has new code, so new tests were added or updated, and they pass.
  • This PR has copy changes, so copy was proofread and approved.
  • The content of this PR requires documentation, so we added a detailed description of component purpose, requirements, quirks, and instructions for use by designers and developers. Along with accessibility information if pertinent.

Browser Testing

[delete if irrelevant to this issue]

Gold Level Browsers

In these browsers, all content is accessible and design matches exactly. In most cases, bugs should be resolved before merge.

macOS

  • Chrome, current release
  • Firefox, current release
  • Safari, current release

Windows

  • Chrome, current release
  • Firefox, current release

Mobile

  • Chrome on Android 9
  • Safari, current release, on iPhone

Silver Level Browsers

In these browsers, all content is readable, but design may be inaccurate.

Windows

  • Edge, current release

Mobile

  • Android 8 - Chrome on Phone
  • Safari, version before current release, on iPad (including various split screen widths)
  • Chrome on iPhone

Bronze Level Browsers

In these browsers, our only goal is content readability.

Windows

  • IE 11

Copy link

netlify bot commented May 28, 2024

Deploy Preview for sb-apprentices ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/sb-apprentices/deploys/665657737c2666ac495182d7
😎 Deploy Preview https://deploy-preview-51--sb-apprentices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant