Keyboard selection behavior and bugfixes. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from normal select boxes.
* changed keyboard selection to behave more like native select boxes
* dropdownSelection doesn't throw an error anymore, if you click on the ul but not on the a element (for example if the ul has padding and someone clicks on the free space)
…down and without triggering change event * up, down keys and search while dropdown is open doesn't trigger change event but update input value and keep dropdown open (just like native selectboxes) * hideDropdown should now work as expected
…ves problem with leading whitespaces)
* improved readability * fixed missing preventDefault, for up,down,right,left keys, if there is no next or prev element
…objects (improved performance and correct behavior for selects with 2 options with the same value) * removed selectboxCounter * performance improvements * cleaned source * event delegation for all events (cleaner source + better performance) * bugfix for scroll position recovery * updated tests to match fixed behavior
…election won't work after scrolling) * more responsive fade animations (stop them that they can't stack if an dropdown gets closed and reopened very fast multiple times) * close dropdown for all mousebuttons for clicks outside the dropdown
|
sorry for this huge pull request, i'll add some comments to the diff to make it more simple to understand.
as soon as the pull request is merged i'll add this two points to the issue tracker. |
| @@ -1,130 +1,192 @@ | |||
| (function($) { | |||
| var selectboxCounter = 0; | |||
There was a problem hiding this comment.
there is no reason to keep selectboxCounter, since data-id isn't in use anymore
| return false; | ||
| } | ||
| }); | ||
| if(hideAfter) $current.parent().hide(); |
There was a problem hiding this comment.
If dropdown was hidden, hide it again. Else keep it open.
| } | ||
|
|
||
| var fixDropdownPositions = function(element) { | ||
| if (settings.appendTo) { |
There was a problem hiding this comment.
Nothing to do if appendTo isn't used.
* improved performance for fixDropdownPositions (important if polling setting is used)
… dropdown has a scrollbar) * updated jQuery version * added compatibility for current jQuery version (dropped compatibility for pre 1.6 jQuery)
… select items, while sb-input isn't in the visible area (scrolling with long dropdowns) in webkit browsers)
…k the first time after scrolling in the dropdown
|
any progress on this? There seems to be some good stuff here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change event should not be fired on init or if value hasn't changed. Additionally the change event should only be fired at the end of a change (when dropdown gets closed). This behavior differed from normal select boxes.
Selection by keyboard had a lot of bugs and didn't behave like native browser checkboxes.
New behavior is:
See commit messages for complete list of bugfixes.
Tested with latest Chrome and Firefox.