Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#173 프로필 이미지 업데이트 profileImageUpdatedAt 속성으로 관리 #424

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

kmc7468
Copy link
Member

@kmc7468 kmc7468 commented Oct 26, 2023

Summary

It closes #173
User Document의 profileImageUrl 필드에, Prefix와 Token을 함께 저장하도록 변경했습니다. 더이상 프론트엔드에서 Token을 매번 갱신하지 않아도 되기 때문에, 캐싱의 효과를 얻을 수 있게 됩니다.

Further Work

  • Nothing

@kmc7468 kmc7468 requested review from cokia, withSang and 14KGun October 26, 2023 14:21
@kmc7468 kmc7468 self-assigned this Oct 26, 2023
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아 보입니다!! 고생하셨어요 :)

Copy link
Contributor

@cokia cokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
CleanShot 2023-10-26 at 23 21 48@2x

@14KGun
Copy link
Member

14KGun commented Jan 2, 2024

@kmc7468 오늘 해볼까요???

@kmc7468
Copy link
Member Author

kmc7468 commented Jan 2, 2024

좋아용

@kmc7468
Copy link
Member Author

kmc7468 commented Jan 2, 2024

@14KGun 충돌 해결했습니다!

@kmc7468 kmc7468 merged commit 299052a into dev Jan 2, 2024
1 check passed
@kmc7468 kmc7468 deleted the #173-profile-image-caching branch January 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 이미지 업데이트 profileImageUpdatedAt 속성으로 관리
4 participants