Migrate redux reducer about write-reviews

src/actions/write-reviews/rankedReviews.ts

@@ -1,27 +1,29 @@
-import Review from '@/shapes/model/review/Review';
-import Semester from '@/shapes/model/subject/Semester';
+import type Review from '@/shapes/model/review/Review';
+import type { SemesterType } from '@/shapes/enum';
 
 const BASE_STRING = 'WR_RR_';
 
 export const RESET = `${BASE_STRING}RESET` as const;
 export const ADD_SEMESTER_REVIEWS = `${BASE_STRING}ADD_SEMESTER_REVIEWS` as const;
 export const SET_SEMESTER_REVIEW_COUNT = `${BASE_STRING}SET_SEMESTER_REVIEW_COUNT` as const;
 
+type SemesterKey = `${number}-${SemesterType}` | 'ALL';
+
 export function reset() {
   return {
     type: RESET,
   };
 }
 
-export function addSemesterReviews(semester: Semester, reviews: Review[]) {
+export function addSemesterReviews(semester: SemesterKey, reviews: Review[]) {
   return {
     type: ADD_SEMESTER_REVIEWS,
     semester: semester,
     reviews: reviews,
   };
 }
 
-export function setSemesterReviewCount(semester: Semester, count: number) {
+export function setSemesterReviewCount(semester: SemesterKey, count: number) {
   return {
     type: SET_SEMESTER_REVIEW_COUNT,
     semester: semester,

src/components/blocks/SemesterBlock.tsx

@@ -22,7 +22,7 @@ interface Props {
 const SemesterBlock: React.FC<Props> = ({ semester, isRaised, onClick }) => {
   const { t } = useTranslation();
 
-  const handleClick = onClick?.(semester);
+  const handleClick = () => onClick?.(semester);
 
   const title =
     semester === 'ALL'

src/reducers/write-reviews/index.js → src/reducers/write-reviews/index.ts

@@ -11,4 +11,5 @@ const CombinedReducer = combineReducers({
   rankedReviews: rankedReviews,
 });
 
+export type WriteReviewsState = ReturnType<typeof CombinedReducer>;
 export default CombinedReducer;

src/reducers/write-reviews/latestReviews.js → src/reducers/write-reviews/latestReviews.ts

@@ -1,21 +1,35 @@
-import { RESET, ADD_REVIEWS, UPDATE_REVIEW } from '../../actions/write-reviews/latestReviews';
+import {
+  RESET,
+  ADD_REVIEWS,
+  UPDATE_REVIEW,
+  LatestReviewsAction,
+} from '@/actions/write-reviews/latestReviews';
+import Review from '@/shapes/model/review/Review';
 
-const initialState = {
+interface LatestReviewsState {
+  reviews: Review[] | null;
+}
+
+const initialState: LatestReviewsState = {
   reviews: null,
 };
 
-const latestReviews = (state = initialState, action) => {
+const latestReviews = (state = initialState, action: LatestReviewsAction) => {
   switch (action.type) {
     case RESET: {
       return initialState;
     }
     case ADD_REVIEWS: {
       const newReviews = [...(state.reviews !== null ? state.reviews : []), ...action.reviews];
-      return Object.assign({}, state, {
+      return {
+        ...state,
         reviews: newReviews,
-      });
+      };
     }
     case UPDATE_REVIEW: {
+      if (!state.reviews) {
+        return state;
+      }
       const originalReviews = state.reviews;
       const { review, isNew } = action;
       const foundIndex = originalReviews.findIndex((r) => r.id === review.id);
@@ -29,9 +43,10 @@
           : isNew
           ? [review, ...originalReviews.slice()]
           : [...originalReviews.slice()];
-      return Object.assign({}, state, {
+      return {
+        ...state,
         reviews: newReviews,
-      });
+      };
     }
     default: {
       return state;

src/reducers/write-reviews/likedReviews.ts

@@ -0,0 +1,25 @@
+import { LikedReviewsAction, RESET, SET_REVIEWS } from '@/actions/write-reviews/likedReviews';
+import Review from '@/shapes/model/review/Review';
+interface LikedReviewsState {
+  reviews: Review[] | null;
+}
+
+const initialState: LikedReviewsState = {
+  reviews: null,
+};
+
+const likedReviews = (state = initialState, action: LikedReviewsAction) => {
+  switch (action.type) {
+    case RESET: {
+      return initialState;
+    }
+    case SET_REVIEWS: {
+      return { ...state, reviews: action.reviews };
+    }
+    default: {
+      return state;
+    }
+  }
+};
+
+export default likedReviews;

src/reducers/write-reviews/rankedReviews.js → src/reducers/write-reviews/rankedReviews.ts

@@ -2,34 +2,47 @@
   RESET,
   ADD_SEMESTER_REVIEWS,
   SET_SEMESTER_REVIEW_COUNT,
-} from '../../actions/write-reviews/rankedReviews';
+  RankedReviewsAction,
+} from '@/actions/write-reviews/rankedReviews';
+import Review from '@/shapes/model/review/Review';
 
-const initialState = {
+interface RankedReviewState {
+  reviewsBySemester: {
+    [semester: string]: Review[];
+  };
+  reviewCountBySemester: {
+    [semester: string]: number;
+  };
+}
+
+const initialState: RankedReviewState = {
   reviewsBySemester: {},
   reviewCountBySemester: {},
 };
 
-const latestReviews = (state = initialState, action) => {
+const latestReviews = (state = initialState, action: RankedReviewsAction) => {
   switch (action.type) {
     case RESET: {
       return initialState;
     }
     case ADD_SEMESTER_REVIEWS: {
       const prevReviewsOfSemester = state.reviewsBySemester[action.semester] || [];
-      return Object.assign({}, state, {
+      return {
+        ...state,
         reviewsBySemester: {
           ...state.reviewsBySemester,
           [action.semester]: prevReviewsOfSemester.concat(action.reviews),
         },
-      });
+      };
     }
     case SET_SEMESTER_REVIEW_COUNT: {
-      return Object.assign({}, state, {
+      return {
+        ...state,
         reviewCountBySemester: {
           ...state.reviewCountBySemester,
           [action.semester]: action.count,
         },
-      });
+      };
     }
     default: {
       return state;

src/reducers/write-reviews/reviewsFocus.js → src/reducers/write-reviews/reviewsFocus.ts

@@ -3,39 +3,51 @@
   SET_REVIEWS_FOCUS,
   CLEAR_REVIEWS_FOCUS,
   SET_REVIEWS,
-} from '../../actions/write-reviews/reviewsFocus';
+  ReviewsFocusAction,
+} from '@/actions/write-reviews/reviewsFocus';
 
 import { ReviewsFocusFrom } from '@/shapes/enum';
+import Review from '@/shapes/model/review/Review';
+import Lecture from '@/shapes/model/subject/Lecture';
 
-const initialState = {
+interface ReviewsFocusState {
+  from: ReviewsFocusFrom;
+  lecture: Lecture | null;
+  reviews: Review[] | null;
+}
+
+const initialState: ReviewsFocusState = {
   from: ReviewsFocusFrom.NONE,
   lecture: null,
   reviews: null,
 };
 
-const reviewsFocus = (state = initialState, action) => {
+const reviewsFocus = (state = initialState, action: ReviewsFocusAction) => {
   switch (action.type) {
     case RESET: {
       return initialState;
     }
     case SET_REVIEWS_FOCUS: {
-      return Object.assign({}, state, {
+      return {
+        ...state,
         from: action.from,
         lecture: action.lecture,
         reviews: null,
-      });
+      };
     }
     case CLEAR_REVIEWS_FOCUS: {
-      return Object.assign({}, state, {
+      return {
+        ...state,
         from: ReviewsFocusFrom.NONE,
         lecture: null,
         reviews: null,
-      });
+      };
     }
     case SET_REVIEWS: {
-      return Object.assign({}, state, {
+      return {
+        ...state,
         reviews: action.reviews,
-      });
+      };
     }
     default: {
       return state;