Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate redux reducer about common #67

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

Davidace136
Copy link
Contributor

@Davidace136 Davidace136 commented May 8, 2024

변경 사항:

  • reducers/common 폴더 하위 js 파일들에 대해 ts로 변경

진행 상황:

  • 코드 수정
  • 테스팅

특이 사항:

  • track.js를 track.ts로 수정 중에 actions/common/track.ts 안에 있는 TracksProps를 사용하는 것이 알맞아 보여 원래 export 되지 않았던 TracksProps를 export 했습니다.

@Davidace136 Davidace136 requested a review from yumincho May 8, 2024 10:53
@Davidace136 Davidace136 self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 4.49%. Comparing base (316d614) to head (6250578).
Report is 16 commits behind head on migration.

❗ Current head 6250578 differs from pull request most recent head 6564ebc. Consider uploading reports for the commit 6564ebc to get more accurate results

Files Patch % Lines
src/reducers/common/media.ts 0.00% 9 Missing ⚠️
src/reducers/common/semester.ts 0.00% 9 Missing ⚠️
src/reducers/common/track.ts 0.00% 9 Missing ⚠️
src/reducers/common/user.ts 0.00% 7 Missing ⚠️
src/actions/common/track.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           migration     #67      +/-   ##
============================================
+ Coverage       4.12%   4.49%   +0.37%     
============================================
  Files            211     210       -1     
  Lines           6547    6517      -30     
  Branches        1686    1639      -47     
============================================
+ Hits             270     293      +23     
+ Misses          6134    6117      -17     
+ Partials         143     107      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Davidace136 Davidace136 requested a review from jooyeongmee May 8, 2024 12:59
src/reducers/common/track.ts Outdated Show resolved Hide resolved
src/reducers/common/user.ts Outdated Show resolved Hide resolved
src/reducers/common/user.ts Outdated Show resolved Hide resolved
@yumincho yumincho changed the title migrate: migrate common reducers Migrate redux reducer about common May 15, 2024
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/reducers/common/user.ts 에서 UserState의 user initialState를
undefined에서 null로 변경하였습니다.

@sboh1214
Copy link
Contributor

추가로 common reducer들에 대해서 이름이 모두 reducer로 지정되어 있고, default export와 export가 중복 적용되어 있어 수정했습니다 (6564ebc)

@sboh1214 sboh1214 merged commit d3fb78c into migration May 16, 2024
3 checks passed
@sboh1214 sboh1214 deleted the migration@reducers/common branch May 16, 2024 12:05
@sboh1214 sboh1214 restored the migration@reducers/common branch May 16, 2024 12:09
@yumincho yumincho added this to the TypeScript Migration milestone May 16, 2024
@yumincho yumincho added the migrate migrate from JS CC to TS FC label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate migrate from JS CC to TS FC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants