Migrate review block and semester block #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
기타 (PR 관련된 사항은 아님) Planner Page 에서 ReviewBlock 이 사용되는데
|
useruseruse
requested review from
sboh1214,
Davidace136,
jooyeongmee,
yumincho and
UrWrstNightmare
sboh1214
force-pushed
the
migration@components/blocks1
branch
from
e2d4751 to
013731b
Compare
sboh1214
requested changes
Mar 25, 2024
| import Semester from '@/shapes/model/subject/Semester'; | ||
| import { getSemesterName } from '@/utils/semesterUtils'; | ||
|
|
||
| type SemesterType = Semester | 'ALL'; |
There was a problem hiding this comment.
만약 이 타입이 다른 곳에서도 사용된다면 shapes 폴더에 저장하는 것이 좋을 것 같아요
sboh1214
changed the title
yumincho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Page - dictionary page 로 잘 이동함
Dictionary Page
Planner Page
Write Review - dictionary page 로 잘 이동함
