Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tile components #51

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Migrate tile components #51

merged 7 commits into from
Mar 25, 2024

Conversation

jooyeongmee
Copy link
Contributor

@jooyeongmee jooyeongmee commented Mar 19, 2024

Description

작업 내용:

  1. @/components/tiles 하위 컴포넌트 .tsx 로 전환
  2. 기존의 i18n.t 사용하던 부분을 useTranslatedString 사용하도록 변경
  3. 컴포넌트 내에서 사용된 utils 함수들 ts 파일 만들어서 기존의 함수 마이그레이션
  4. 컴포넌트가 사용된 위치 파악하면서 해당 컴포넌트 설명 주석 추가

Checklist

  • HorizontalTimetableTile.tsx
  • PlannerTile.tsx
image
  • TimetableDragTile.tsx
image
  • TimetableTile.tsx
image

참고사항

TimetableDragTile을 제외하곤 utils 함수들이나 다른 컴포넌트에 의존하여 일단 모두 jsx 파일 삭제하지 않고 tsx 파일만 추가했습니다.
삭제가 필요하면 코멘트 남겨주세요:)

Sorry, something went wrong.

@jooyeongmee jooyeongmee added the migrate migrate from JS CC to TS FC label Mar 19, 2024
@jooyeongmee jooyeongmee self-assigned this Mar 19, 2024
@jooyeongmee jooyeongmee marked this pull request as ready for review March 20, 2024 00:42
interface Props {
item: ItemType;
yearIndex: number;
semesterIndex: 0 | 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 | 1 이 어떤 걸 뜻하는지 주석이 있는것도 좋을 것 같아요

Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)
기존 jsx파일은 삭제하시고 새 tsx 컴포넌트가 잘 작동하는지 테스트해보시고 PR 설명에 스크린샷 함께 첨부해 주시면 좋을 것 같습니다.

@sboh1214 sboh1214 changed the title Migrate tiles Migrate tile components Mar 20, 2024
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
아래 코드 제안드립니다 :)

onMouseOver && (() => onMouseOver(item));
onMouseOver?.(item);

@sboh1214 sboh1214 merged commit 99645fd into migration Mar 25, 2024
3 checks passed
@sboh1214 sboh1214 deleted the migration@components/tiles branch March 25, 2024 15:58
@yumincho yumincho added this to the TypeScript Migration milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate migrate from JS CC to TS FC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants