-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tile components #51
Conversation
interface Props { | ||
item: ItemType; | ||
yearIndex: number; | ||
semesterIndex: 0 | 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 | 1 이 어떤 걸 뜻하는지 주석이 있는것도 좋을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 :)
기존 jsx파일은 삭제하시고 새 tsx 컴포넌트가 잘 작동하는지 테스트해보시고 PR 설명에 스크린샷 함께 첨부해 주시면 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
아래 코드 제안드립니다 :)
onMouseOver && (() => onMouseOver(item));
onMouseOver?.(item);
Description
작업 내용:
Checklist
참고사항
TimetableDragTile을 제외하곤 utils 함수들이나 다른 컴포넌트에 의존하여 일단 모두 jsx 파일 삭제하지 않고 tsx 파일만 추가했습니다.
삭제가 필요하면 코멘트 남겨주세요:)