Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to department.tsx, semester.tsx, course.tsx #37

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Migrate to department.tsx, semester.tsx, course.tsx #37

merged 1 commit into from
Mar 11, 2024

Conversation

Davidace136
Copy link
Contributor

  • department.tsx
  • semester.tsx
  • course.tsx

@Davidace136 Davidace136 self-assigned this Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-11 09:07 UTC

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

[PR Preview GH Proxy (on bap)]
👍 Proxied Github Pages Preview URL to http://pr-37.otl-pr-preview.sparcsandbox.com/index.html
Proudly Powered by [email protected]

@Davidace136 Davidace136 marked this pull request as ready for review March 6, 2024 14:04
@Davidace136 Davidace136 requested a review from yumincho March 6, 2024 14:05
@Davidace136 Davidace136 added the migrate migrate from JS CC to TS FC label Mar 6, 2024
@yumincho yumincho changed the title migrate: to 'department.tsx' 'semester.tsx' 'course.tsx' Migrate: to department.tsx, semester.tsx, course.tsx Mar 11, 2024
@yumincho yumincho changed the title Migrate: to department.tsx, semester.tsx, course.tsx Migrate to department.tsx, semester.tsx, course.tsx Mar 11, 2024
@yumincho yumincho requested a review from sboh1214 March 11, 2024 03:23
@sboh1214 sboh1214 deleted the branch migration March 11, 2024 08:51
@sboh1214 sboh1214 closed this Mar 11, 2024
@sboh1214 sboh1214 reopened this Mar 11, 2024
@sboh1214 sboh1214 force-pushed the migration@shape/subject1 branch from cb1c65e to 1b2234b Compare March 11, 2024 09:03
@sboh1214 sboh1214 force-pushed the migration@shape/subject1 branch from 1b2234b to 5abec48 Compare March 11, 2024 09:04
sboh1214
sboh1214 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sboh1214 sboh1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@sboh1214 sboh1214 merged commit 3ba882b into migration Mar 11, 2024
4 checks passed
@sboh1214 sboh1214 deleted the migration@shape/subject1 branch March 11, 2024 09:07
@yumincho yumincho added this to the TypeScript Migration milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboh1214 sboh1214 sboh1214 approved these changes

@yumincho yumincho yumincho approved these changes

Assignees

@Davidace136 Davidace136

Labels
migrate migrate from JS CC to TS FC
Projects
None yet
Milestone
Refactoring & Migration
Development

Successfully merging this pull request may close these issues.
3 participants
@Davidace136 @sboh1214 @yumincho