Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stf_lib CTest regression #37

Merged

Conversation

StanSofomoDev
Copy link
Contributor

This pull request introduces a regression target for unit testing STF_LIB using CTest. The regression tests can be executed with the following commands:

mkdir -p release/
cd release/
cmake .. -DCMAKE_BUILD_TYPE=Release
make -j32 regress
cd ..

Currently, these tests serve as a stub and do not cover the STF_LIB extensively (only one basic STFWriter test was added).

@bdutro bdutro requested review from bdutro and klingaard June 14, 2024 21:21
Copy link
Member

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! And appreciated. One thing this doesn't really test is making sure the file written contains the expected information written. Suggest adding an stf_reader after the close and making sure the file read matches what was written.

tests/stf_writer_test/CMakeLists.txt Show resolved Hide resolved
tests/stf_writer_test/CMakeLists.txt Show resolved Hide resolved
@StanSofomoDev
Copy link
Contributor Author

This is great! And appreciated. One thing this doesn't really test is making sure the file written contains the expected information written. Suggest adding an stf_reader after the close and making sure the file read matches what was written.

Written file contents are tested by diff comparison to golden file that is included in the test directory.

@StanSofomoDev
Copy link
Contributor Author

@bdutro, @klingaard, main purpose for this PR is to add CTest environment to the stf_lib, proper tests that would cover components of the stf_lib can be added in the future.

@bdutro
Copy link
Collaborator

bdutro commented Jun 17, 2024

This all looks good. Could you go ahead and add a make regress call to https://github.com/sparcians/stf_lib/blob/master/.github/workflows/ubuntu-build.yml so it runs for PRs?

Copy link
Collaborator

@bdutro bdutro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdutro bdutro merged commit f87fbe5 into sparcians:master Jun 18, 2024
1 check passed
@StanSofomoDev StanSofomoDev deleted the siwan/duplicate_ctest_environment branch June 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants