-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stf_lib CTest regression #37
stf_lib CTest regression #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! And appreciated. One thing this doesn't really test is making sure the file written contains the expected information written. Suggest adding an stf_reader
after the close and making sure the file read matches what was written.
Written file contents are tested by diff comparison to golden file that is included in the test directory. |
@bdutro, @klingaard, main purpose for this PR is to add CTest environment to the |
This all looks good. Could you go ahead and add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces a regression target for unit testing STF_LIB using CTest. The regression tests can be executed with the following commands:
Currently, these tests serve as a stub and do not cover the STF_LIB extensively (only one basic STFWriter test was added).