Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAX: add v0.4.32+ #46346

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

JAX: add v0.4.32+ #46346

wants to merge 34 commits into from

Conversation

@adamjstewart
Copy link
Member Author

adamjstewart commented Sep 17, 2024

@adamjstewart adamjstewart force-pushed the packages/jax branch 2 times, most recently from 511ac79 to 25d8353 Compare September 21, 2024 14:41
wdconinc
wdconinc previously approved these changes Sep 24, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checksums verified. Do you want to add py-jaxlib@=0.4.33 too now that it's out?

Deferring to maintainer on the py-jaxlib modifications, which are exercised in CI builds.

@wdconinc wdconinc self-assigned this Sep 24, 2024
@adamjstewart
Copy link
Member Author

jaxlib 0.4.33 hasn't been released on GitHub yet.

@wdconinc
Copy link
Contributor

jaxlib 0.4.33 hasn't been released on GitHub yet.

You're right (of course). I mixed up jax and jaxlib.

@wdconinc
Copy link
Contributor

I also see the CI build errors now.

@adamjstewart
Copy link
Member Author

Yep. One of them is fixed in main, but not the other one. So I'm waiting to decide whether or not to backport the patch. JAX completely changed its entire build system to make it more difficult to use external CUDA and friends.

@aweits
Copy link
Contributor

aweits commented Oct 9, 2024

currently not building for me...

DEBUG: /scratch.local/spack7ucgbc8b/0811568bf239883f388d364b3e2f09d5/external/tsl/third_party/gpus/cuda/hermetic/cuda_configure.bzl:50:14: Cannot find None, either correct your path, or set the CLANG_CUDA_COMPILER_PATH or CC environment variables

build script for tsl looks to be missing some vars -- digging....

# Template values set by cuda_autoconf.
CPU_COMPILER = ('')
HOST_COMPILER_PATH = ('')

@adamjstewart
Copy link
Member Author

Which compiler are you using?

@adamjstewart
Copy link
Member Author

I have no idea how to fix the CPU installation and the GPU build is still quite broken. And I can't even build bazel on macOS, so I can't easily debug anything. So I'm definitely going to need help on this one. We either need to finish this or backport some complicated thing to get the aarch64 tests to pass, and I would rather finish this if possible.

@adamjstewart adamjstewart changed the title JAX: add v0.4.32 JAX: add v0.4.32+ Oct 23, 2024
@wdconinc
Copy link
Contributor

This PR needs a rebase after #47260

@jonas-eschle
Copy link
Contributor

Are there any news on this? It's holding up quite a few PRs, starting from TFP: #43688

@adamjstewart
Copy link
Member Author

No solutions from upstream JAX maintainers, hoping @aweits or someone else can figure out how to get this to build because I can't.

@spackbot-app spackbot-app bot added the patch label Dec 13, 2024
@adamjstewart
Copy link
Member Author

New bug: jax-ml/jax#25488

@adamjstewart
Copy link
Member Author

Well, the build almost completes, but I can't even find an error message now.

@adamjstewart
Copy link
Member Author

x86_64 build is working now, still need to fix the aarch64 build: jax-ml/jax#25598

@adamjstewart
Copy link
Member Author

x86_64 CUDA build is still failing: jax-ml/jax#23689 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants