Installer: queue only link/run deps unless building from source #46101
+400
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
binary-packages
commands
core
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
2 times, most recently
from
e7980d2 to
fbc7ad9
Compare
tldahlgren
force-pushed
the
features/install-binary-no-build-deps
branch
from
d6d8dbb to
085cff4
Compare
tldahlgren
reviewed
Sep 5, 2024
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
2 times, most recently
from
52ec48e to
63c8bd6
Compare
tldahlgren
reviewed
Sep 5, 2024
| "The spec is now uninstalled." | ||
| ) | ||
|
|
||
| # Unwrap the actuall installation exception |
There was a problem hiding this comment.
Typo: actuall -> actual.
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
3 times, most recently
from
5e8476b to
c0e596c
Compare
…eded Refactors BuildTask into separate classes BuildTask and InstallTask Queues all packages as InstallTask, with link/run deps only If an InstallTask fails to install from binary, a BuildTask is generated The BuildTask is queued with dependencies on the new InstallTasks for its build deps and their link/run dependencies. The Tasks telescope open to include all build deps of build deps ad-hoc
becker33
force-pushed
the
features/install-binary-no-build-deps
branch
from
c0e596c to
e8327bc
Compare
4 tasks
- test/installer: use existing inst for spack.installer
- remove install status from Installing message
- Add specs count visitor
- Report status on installed plus minor refactor
- Add the "+" to the tracker; include one experimental dynamic calculation
- tweak status reporting to include ensuring numerator unique across installed packages
- _print_installed_pkg -> InstallStatus.print_installed()
- move set_term_title outside of InstallStatus
- InstallStatus: remove unnecessary next_pkg
- InstallStatus: class and method name changes
* changed InstallStatus to InstallerStatus since already have former in
database.py and spec.py
* changed print_installed to set_installed since does more than print now
- InstallerStatus -> InstallerProgress, install_status -> progress
- InstallerProgress: cache config:install_status
- InstallerProgress: restore get_progress and set_term_title methods (w/ tweaks)
- Task execute(): added returns to docstrings
- Don't pass progress to build_process or Installer.run, but set installed on successful return
- fix mypy issue with pkg.run_tests assignment
tldahlgren
force-pushed
the
features/install-binary-no-build-deps
branch
from
7261682 to
58ed9be
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #39136 (commits up-to/including 39ff are from that PR)
TODO: