Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create db if doesn't exist #37

Merged
merged 4 commits into from
May 1, 2024
Merged

Create db if doesn't exist #37

merged 4 commits into from
May 1, 2024

Conversation

cmelone
Copy link
Collaborator

@cmelone cmelone commented Apr 23, 2024

Provides a mechanism for database initialization if it doesn't exist from within the container.

This will require some re-engineering if we need to apply migrations in the future.

@cmelone cmelone added the config Modifications to App Configuration label Apr 23, 2024
@cmelone cmelone requested a review from alecbcs April 23, 2024 20:45
@cmelone cmelone self-assigned this Apr 23, 2024
I have no idea why, but Litestream sets a replicated file's
permissions to 600 [0], which makes it impossible to access
from a rootless container, if the file is being exposed through
a volume.

[0] https://github.com/benbjohnson/litestream/blob/5be467a478adcffc5b3999b9503cc676c2bf09f1/internal/internal.go#L62
cmelone added a commit to cmelone/spack-infrastructure that referenced this pull request Apr 25, 2024
@cmelone cmelone changed the title Database initialization mechanism Create db if doesn't exist Apr 25, 2024
Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @cmelone!

@alecbcs alecbcs merged commit d3f5f1c into develop May 1, 2024
5 checks passed
@alecbcs alecbcs deleted the add/sqlite-init-container branch May 1, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Modifications to App Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants