-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection API #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice job! This PR looks great. Just a couple points of feedback.
I also might suggest creating the sqlite db in the root of the repo and actually putting db/
under gantry/
instead of leaving it as its own top level component. This might fit a bit better depending on how we structure the components. I'd probably go for something like the following, but feel free to push back if you don't find that as easy to work with.
gantry/
db/
get.py
insert.py
clients/
prometheus.py
gitlab.py
models/
jobs.py
vms.py
routes/
collection.py
__main__.py
Co-authored-by: Alec Scott <[email protected]>
I like this! Should I stick the |
Going to tackle testing in another PR to avoid adding too much more to this. marking this one as ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of the rewrite! Just a few small nitpicks neither of which are real blockers if you prefer keeping as is. Otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @cmelone thank you for all of your work on this!
This PR implements a webhook for the status change of Gitlab jobs. Build jobs are selected for processing, where a series of Prometheus queries are issued and data about the build and resource utilization are made available.
Adds:
POST
endpoint under/collect
.Priorities:
All main functionality is implemented and I have removed the draft status from the PR. There are just a couple more things to do:
spack-infrastructure!733
is merged, make sure that stack is being properly collected in the dataAlso, I realize that this PR is quite big, so I'm happy to break it up into smaller pieces.