Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rolling back to Sphinx v5 as v6-8 introduce issues on ReadTheDocs #2050

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

shachafl
Copy link
Collaborator

@shachafl shachafl commented Feb 7, 2025

Sphinx v6-8 introduce issues on ReadTheDocs navbar Starfish logo (top left) and dropdown "More" sub-menu (see below).
Could also be with relation to other dependencies, like: docutils, sphinx-rtd-theme, etc...

In Sphinx v6 the left logo disappears but dropdown menu still works, and the dropdown stops working in v7-8
image

Rolling back to Sphinx v5 and some related dependencies solves the issue:
image

@shachafl shachafl added the docs documentation improvements label Feb 7, 2025
@shachafl shachafl requested a review from berl February 7, 2025 20:19
Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. And the other various version bumps are due to pip-tools keeping everything else up to date?

@shachafl shachafl merged commit bcce097 into spacetx:master Feb 9, 2025
29 checks passed
@shachafl
Copy link
Collaborator Author

shachafl commented Feb 9, 2025

Yes, minor upgrades to other dependencies.
FYI, I ended up removing pip-tools to keep the same method used in the Makefile for dependency updates.

@shachafl shachafl deleted the shachafl-rtd-navbar-fix branch February 9, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sphinx html latest build issues with missing top left icon and dropdown menu not working
2 participants