Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to design & layout of docs #1875

Merged
merged 9 commits into from
Apr 21, 2020
Merged

Conversation

neuromusic
Copy link
Collaborator

@neuromusic neuromusic commented Apr 21, 2020

@neuromusic neuromusic requested a review from mattcai April 21, 2020 14:02
@neuromusic
Copy link
Collaborator Author

fixes #1861

@codecov-io
Copy link

codecov-io commented Apr 21, 2020

Codecov Report

Merging #1875 into master will decrease coverage by 31.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1875       +/-   ##
===========================================
- Coverage   87.77%   55.95%   -31.83%     
===========================================
  Files         168      168               
  Lines        5785     5785               
===========================================
- Hits         5078     3237     -1841     
- Misses        707     2548     +1841     
Impacted Files Coverage Δ
starfish/morphology.py 0.00% <0.00%> (-100.00%) ⬇️
...ish/core/imagestack/parser/tilefetcher/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...fish/core/imagestack/parser/tilefetcher/_parser.py 0.00% <0.00%> (-90.33%) ⬇️
starfish/test/full_pipelines/api/test_dartfish.py 19.67% <0.00%> (-80.33%) ⬇️
starfish/core/spots/DecodeSpots/util.py 20.40% <0.00%> (-79.60%) ⬇️
starfish/test/full_pipelines/api/test_iss_api.py 22.22% <0.00%> (-77.78%) ⬇️
...e/experiment/builder/test/factories/all_purpose.py 22.91% <0.00%> (-77.09%) ⬇️
starfish/core/starfish.py 0.00% <0.00%> (-76.93%) ⬇️
starfish/test/full_pipelines/api/test_merfish.py 23.80% <0.00%> (-76.20%) ⬇️
...ilder/test/structured_formatter/test_single_fov.py 25.71% <0.00%> (-74.29%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f21a33...4f2c77e. Read the comment docs.

Copy link
Contributor

@mattcai mattcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it looks so much better now!

@neuromusic neuromusic merged commit 0291e00 into master Apr 21, 2020
@neuromusic neuromusic deleted the jk/css-improvements branch April 21, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants