-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate jwst/romancal pytest configuration #297
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 81.80% 86.21% +4.40%
==========================================
Files 46 47 +1
Lines 8810 8812 +2
==========================================
+ Hits 7207 7597 +390
+ Misses 1603 1215 -388 ☔ View full report in Codecov by Sentry. |
97f5a2d
to
f96d709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changes fragment for the change log, but otherwise fine.
Thanks! I pushed on in 24b0a2b I gave it the 'general' category. I originally left one off since this is all internal/testing changes. If it's helpful to have these in the changelog we could add a 'testing' catagory for these types of changes. |
24b0a2b
to
9cc2e10
Compare
Hey, the diff --git a/tox.ini b/tox.ini
index 14937c2..8819ecf 100644
--- a/tox.ini
+++ b/tox.ini
@@ -2,7 +2,7 @@
envlist =
check-{style,build,types}
test{,-warnings,-cov}-xdist
- test-numpy{120,121,122}
+ test-numpy{123,124,125,126}
test-{jwst,romancal}{,-xdist}{,-cov}
build-{docs,dist}
@@ -69,6 +69,10 @@ deps =
devdeps: asdf @ git+https://github.com/asdf-format/asdf.git
devdeps: drizzle @ git+https://github.com/spacetelescope/drizzle.git
devdeps: gwcs @ git+https://github.com/spacetelescope/gwcs.git
+ numpy123: numpy<1.24.0,>=1.23.0
+ numpy124: numpy<1.25.0,>=1.24.0
+ numpy125: numpy<1.26.0,>=1.25.0
+ numpy126: numpy<2.0.0,>=1.26.0
use_develop = true
pass_env =
CI
EDIT: Tox silently ignored 1.20 through 1.22. Packages in the environment must be forcing it to update to 2.x. |
9cc2e10
to
60bd3b8
Compare
Thanks for finding that. I removed those from the envlist in 60bd3b8 The oldestdeps job should check the lower numpy pin, the "normal" jobs the latest release and the devdeps the dev version so I think we have numpy well covered by those. |
No problem! I don't see anything else that jumps out at me. |
Currently downstream testing of jwst and romancal end up using the pyproject.toml in this repository for determining pytest configuration.
https://github.com/spacetelescope/stcal/actions/runs/11142379456/job/30965215790#step:10:107
This ends up with pytest using options in these downstream tests that differ from the options used by the downstream packages in their tests (when run in their own CI). This in turn results in lots of false failures in our downstream testing.
This PR changes how the jwst and romancal downstream tests to use the pytest options defined in the respective repositories.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stcal@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
changes/<PR#>.apichange.rst
: change to public APIchanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.general.rst
: infrastructure or miscellaneous change