update checklist for new pull requests #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
force-pushed
the
update/pull_request_template
branch
2 times, most recently
from
1a87e19
to
36fe5a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 84.63% 84.65% +0.02%
==========================================
Files 41 41
Lines 7628 7651 +23
==========================================
+ Hits 6456 6477 +21
- Misses 1172 1174 +2 ☔ View full report in Codecov by Sentry. |
kmacdonald-stsci
approved these changes
Sep 10, 2024
braingram
requested changes
Sep 10, 2024
zacharyburnett
force-pushed
the
update/pull_request_template
branch
from
3ac95b1
to
329b515
Compare
zacharyburnett
force-pushed
the
update/pull_request_template
branch
from
329b515
to
b1b7544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restructure the pull request checklist to be more useful and less clunky
old checklist
Checklist
for a public change, added a towncrier news fragment in
changes/:echo "changed something" > changes/<PR#>.<changetype>.rstchanges/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous changeupdated relevant tests
updated relevant documentation
updated relevant milestone(s)
added relevant label(s)
new checklist
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change