-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional parameter to alignment methods and handle catalog web service connection issues. #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good to me pending the jwst downstream tests. Why did you add the no_changelog_entry_needed tag? It seems to me it would be useful to know which PR added these changes just in case it does affect something unexpectedly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 84.63% 84.65% +0.02%
==========================================
Files 41 41
Lines 7628 7651 +23
==========================================
+ Hits 6456 6477 +21
- Misses 1172 1174 +2 ☔ View full report in Codecov by Sentry. |
I did that temporarily -- it's still a draft PR. I am working on the changelog entry now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: downstream JWST failures match the most recent test on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the docs build, everything else is the same as before and approved as far as I'm concerned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fielding my last-minute questions.
Resolves RCAL-908
This PR add an optional parameter --
clip_accum
-- to the alignment methods instcal.tweakreg
. This is necessary because JWST and Roman do not use the same value when it comes to that parameter. The default value for that parameter inalign_wcs()
is False, which is what JWST uses. However,clip_accum=True
seems to significantly improve the fitting results for Roman (as compared withclip_accum=False
).This PR also adds the ability to better handle catalog web services connectivity issues.
Checklist
for a public change, added a towncrier news fragment in
changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
changes/<PR#>.apichange.rst
: change to public APIchanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.general.rst
: infrastructure or miscellaneous changeupdated relevant tests
updated relevant documentation
updated relevant milestone(s)
added relevant label(s)