Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter to alignment methods and handle catalog web service connection issues. #286

Merged
merged 11 commits into from
Sep 10, 2024

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Sep 4, 2024

Resolves RCAL-908

This PR add an optional parameter -- clip_accum -- to the alignment methods in stcal.tweakreg. This is necessary because JWST and Roman do not use the same value when it comes to that parameter. The default value for that parameter in align_wcs() is False, which is what JWST uses. However, clip_accum=True seems to significantly improve the fitting results for Roman (as compared with clip_accum=False).

This PR also adds the ability to better handle catalog web services connectivity issues.

Checklist

  • for a public change, added a towncrier news fragment in changes/:

    echo "changed something" > changes/<PR#>.<changetype>.rst

    • changes/<PR#>.apichange.rst: change to public API
    • changes/<PR#>.bugfix.rst: fixes an issue
    • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • updated relevant tests

  • updated relevant documentation

  • updated relevant milestone(s)

  • added relevant label(s)

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me pending the jwst downstream tests. Why did you add the no_changelog_entry_needed tag? It seems to me it would be useful to know which PR added these changes just in case it does affect something unexpectedly

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (d85f859) to head (886ba82).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/tweakreg/astrometric_utils.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   84.63%   84.65%   +0.02%     
==========================================
  Files          41       41              
  Lines        7628     7651      +23     
==========================================
+ Hits         6456     6477      +21     
- Misses       1172     1174       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mairanteodoro
Copy link
Collaborator Author

mairanteodoro commented Sep 4, 2024

Why did you add the no_changelog_entry_needed tag?

I did that temporarily -- it's still a draft PR. I am working on the changelog entry now.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: downstream JWST failures match the most recent test on main

@mairanteodoro mairanteodoro marked this pull request as ready for review September 5, 2024 13:19
@mairanteodoro mairanteodoro requested a review from a team as a code owner September 5, 2024 13:19
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the docs build, everything else is the same as before and approved as far as I'm concerned

@mairanteodoro mairanteodoro requested review from kmacdonald-stsci and removed request for a team September 5, 2024 21:37
changes/286.general.rst Show resolved Hide resolved
changes/286.general.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fielding my last-minute questions.

@mairanteodoro mairanteodoro merged commit 1cf55ef into spacetelescope:main Sep 10, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants