Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3593: 2nd group saturation part 2 #283

Merged
merged 9 commits into from
Sep 19, 2024

Conversation

drlaw1558
Copy link
Contributor

@drlaw1558 drlaw1558 commented Aug 26, 2024

Ready for review: this addresses JP-3593, flagging cosmic ray saturation in group 2 data in a consistent manner between both IRS2 and non-IRS2 modes using the new use_readpatt keyword. This PR is tied to JWST PR spacetelescope/jwst#8731

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@drlaw1558 drlaw1558 requested a review from a team as a code owner August 26, 2024 16:51
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (375f310) to head (3b924fb).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   84.69%   84.74%   +0.04%     
==========================================
  Files          44       44              
  Lines        8501     8527      +26     
==========================================
+ Hits         7200     7226      +26     
  Misses       1301     1301              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drlaw1558
Copy link
Contributor Author

@tapastro Should now be ready for review.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a good algorithm to me. Thank you for making it handle ~arbitrary read patterns!

CHANGES.rst Outdated Show resolved Hide resolved
@tapastro
Copy link
Collaborator

Running a set of regression tests on the PR pair here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1722/

@tapastro tapastro requested a review from a team September 19, 2024 19:50
@tapastro tapastro merged commit ef2c65f into spacetelescope:main Sep 19, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants