Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure extension modules are present in built wheel #256

Merged
merged 3 commits into from
May 17, 2024

Conversation

zacharyburnett
Copy link
Collaborator

Resolves SCSB-149

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (af5aefb) to head (ccbc897).
Report is 5 commits behind head on main.

Current head ccbc897 differs from pull request most recent head 216c0a7

Please upload reports for the commit 216c0a7 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   85.18%   84.99%   -0.19%     
==========================================
  Files          35       35              
  Lines        6797     6865      +68     
==========================================
+ Hits         5790     5835      +45     
- Misses       1007     1030      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as draft May 6, 2024 16:43
@zacharyburnett zacharyburnett marked this pull request as ready for review May 6, 2024 17:22
@@ -23,5 +23,6 @@ jobs:
# Until we have arm64 runners, we can't automatically test arm64 wheels
- cp3*-macosx_arm64
sdist: true
test_command: python -c "from stcal.ramp_fitting.ols_cas22 import _ramp, _jump, _fit"
Copy link
Collaborator Author

@zacharyburnett zacharyburnett May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after merging #156, add its module to the test command:

Suggested change
test_command: python -c "from stcal.ramp_fitting.ols_cas22 import _ramp, _jump, _fit"
test_command: python -c "from stcal.ramp_fitting.ols_cas22 import _ramp, _jump, _fit; from stcal.ramp_fitting import slope_fitter"

@zacharyburnett zacharyburnett merged commit a99a933 into spacetelescope:main May 17, 2024
44 of 47 checks passed
@zacharyburnett zacharyburnett deleted the scsb149 branch May 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants