Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jump.py to limit the number of slices #176

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

mwregan2
Copy link
Collaborator

@mwregan2 mwregan2 commented Jun 28, 2023

For multi-processing, make sure that the number of slices is not larger than the number of rows. Fixes failures seen in unit tests when the number of cores is "all".

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Make sure than the number of slices is not larger than the number of rows.
@mwregan2 mwregan2 requested a review from a team as a code owner June 28, 2023 15:53
@github-actions github-actions bot added the jump label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a7351de) 74.47% compared to head (669a06f) 74.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   74.47%   74.46%   -0.02%     
==========================================
  Files          29       29              
  Lines        5936     5937       +1     
==========================================
  Hits         4421     4421              
- Misses       1515     1516       +1     
Impacted Files Coverage Δ
src/stcal/jump/jump.py 63.79% <0.00%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse added the bug Something isn't working label Jun 28, 2023
CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and CI tests all pass.

@hbushouse hbushouse merged commit 636c9b1 into spacetelescope:main Jun 28, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants