Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3242: Proper Handling of Timing for Final Slope Computation for only 0th Good Group Ramps #173

Merged
merged 13 commits into from
Jun 22, 2023
Merged

JP-3242: Proper Handling of Timing for Final Slope Computation for only 0th Good Group Ramps #173

merged 13 commits into from
Jun 22, 2023

Commits on Jun 8, 2023

  1. Removing some usage of effintim and replacing it with group_time.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    f9d2fa9 View commit details
    Browse the repository at this point in the history

  2. Removing unnecessary 'effintim' variable, which is just the group time.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    affb6e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Updating timing for special cases.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    14f8e86 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Updating computation of slopes for ramps that have the only good grou… 

    …p in the 0th group.
    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    fea0d20 View commit details
    Browse the repository at this point in the history

  2. Updating the ZEROFRAME slope computation.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9dadd21 View commit details
    Browse the repository at this point in the history

  3. Removing unneeded comments.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    b53b91b View commit details
    Browse the repository at this point in the history

  4. Removing development code and comments.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a759c59 View commit details
    Browse the repository at this point in the history

  5. Cleaning up code.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e7e79dc View commit details
    Browse the repository at this point in the history

  6. Updating the comments for the computation of one good 0th group ramps… 

    …. This now is keyed off nframes, rather than groupgap.
    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c6bd9fa View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Updating code style failures and removing unnecessary debugging funct… 

    …ions.
    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    fe767dc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Updating the change log and updating the group time in tests that had… 

    … bad definitions for group time.
    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3a30a4c View commit details
    Browse the repository at this point in the history

  2. Corrected optional results calculations.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1e70cb6 View commit details
    Browse the repository at this point in the history

  3. Removing unneeded comments.

    @kmacdonald-stsci
    kmacdonald-stsci committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2f2b9cf View commit details
    Browse the repository at this point in the history