JP-3689: Fix logic operator (#285)

spacetelescope · Sep 10, 2024 · c23ac15 · c23ac15
2 parents eb35e2a + 3b0f596
commit c23ac15
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changes/285.bugfix.rst b/changes/285.bugfix.rst
@@ -0,0 +1 @@
+[jump] Fix a logical bug in the jump step for usage of > vs >= per JP-3689.
diff --git a/src/stcal/jump/jump.py b/src/stcal/jump/jump.py
@@ -972,7 +972,7 @@ def find_faint_extended(
 
     first_diffs_masked = np.ma.masked_array(first_diffs, mask=np.isnan(first_diffs))
     warnings.filterwarnings("ignore")
-    if nints > minimum_sigclip_groups:
+    if nints >= minimum_sigclip_groups:
         mean, median, stddev = stats.sigma_clipped_stats(first_diffs_masked, sigma=5, axis=0)
     else:
         median_diffs = np.nanmedian(first_diffs_masked, axis=(0, 1))