Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update labeler to v5 #1333

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

zacharyburnett
Copy link
Collaborator

follow-on to #1231 and #1332

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@braingram
Copy link
Collaborator

Do you want to hold off on #1332 in favor of this?

@zacharyburnett
Copy link
Collaborator Author

Do you want to hold off on #1332 in favor of this?

That should work!

@zacharyburnett zacharyburnett marked this pull request as ready for review July 26, 2024 14:59
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 26, 2024 14:59
@braingram
Copy link
Collaborator

I opened a test PR against the source branch (which should trigger the run with the updated config and labeler v5). When you have a chance would you allow the CI to run on that PR?
zacharyburnett#2

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (73e8b77) to head (57425f5).
Report is 185 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   79.05%   79.05%           
=======================================
  Files         117      117           
  Lines        7846     7846           
=======================================
  Hits         6203     6203           
  Misses       1643     1643           
Flag Coverage Δ *Carryforward flag
nightly 63.36% <ø> (ø) Carriedforward from 73e8b77

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test PR worked! Thanks for updating the config file.

@braingram braingram merged commit cae1d64 into spacetelescope:main Jul 26, 2024
29 of 34 checks passed
@zacharyburnett zacharyburnett deleted the labeler/v5 branch July 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants