Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test that ApcorrRefModel arrays can be None #460

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

braingram
Copy link
Collaborator

This PR adds a test that checks if ApcorrRefModel arrays can be None.

The test fails with rad main and all versions of asdf due to a bug in the datatype validator.

spacetelescope/rad#542 works around the issue until an upstream fix and release can be made by reordering the None check in the anyOf combiner. The test added in this PR will provide some safeguard against reintroduction of this bug.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.25%. Comparing base (087a60d) to head (5950aaa).
Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   97.56%   97.25%   -0.31%     
==========================================
  Files          30       37       +7     
  Lines        2788     3315     +527     
==========================================
+ Hits         2720     3224     +504     
- Misses         68       91      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 12, 2025 19:02
@braingram braingram requested a review from a team as a code owner February 12, 2025 19:02
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@schlafly schlafly merged commit a601ee7 into spacetelescope:main Feb 13, 2025
18 of 19 checks passed
@braingram braingram deleted the apcorr_fix branch February 13, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants