Rename source_detection to source_catalog

[braingram]

This PR:

• renames meta.source_detection to meta.source_catalog to align the name with the SourceCatalogStep that assigns this attribute.
• renames meta.cal_step.source_detection to meta.cal_step.source_catalog
• resolves the naming conflict with the source_catalog schema (used for SourceCatalog) caused by the above by renaming this to image_source_catalog (which agrees with mosaic_source_catalog)

See spacetelescope/romancal#1533 for more details.

Tasks

• Update or add relevant rad tests.
• Update relevant docstrings and / or docs/ page.
• Does this PR change any schema files?
  • Schema changes were discussed at RAD Review Board meeting.
• Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
  • Write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types).
  • Start a romancal regression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").
  • Update relevant roman_datamodels utilities and tests.

News fragment change types:

• changes/<PR#>.feature.rst: new feature
• changes/<PR#>.bugfix.rst: fixes an issue
• changes/<PR#>.doc.rst: documentation change
• changes/<PR#>.removal.rst: deprecation or removal of public API
• changes/<PR#>.misc.rst: infrastructure or miscellaneous change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (712888b) to head (a60eed1).
Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files           4        4           
  Lines         213      213           
=======================================
  Hits          205      205           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[braingram]

As this PR renames meta.cal_step.source_detection to meta.cal_step.source_catalog it likely makes sense to also rename the archive_catalog information:

rad/src/rad/resources/schemas/l2_cal_step-1.0.0.yaml

Line 99 in 8dfcfbf

destination: [ScienceRefData.s_source_detection]

This PR does not make that change (but I'm happy to add it) since that will need to be coordinated with the archive.

@PaulHuwe Is there a point of contact that can help answer what's required to update the archive_catalog entry?

[schlafly]

Jason and Kim (already reviewers on this PR) are the relevant contacts there.

[PaulHuwe]

One question, but otherwise looks good. Please be sure to coordinate the catalog names with @kdupriestsci or @jbrookens before merging.