Remove usage of pkg_resources
#356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfixstsci
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
This is great, we have been seeing some issues with packages that have dependencies on pysiaf so I am hoping this alleviates the issues we are seeing. Also, perfect timing because @Witchblade101 and I are planning on performing a release this afternoon so we will get this in too.
Thanks I'm glad to help, I ran into an issue related to this, this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resourceswas deprecated way back inpython 3.10for removal inpython 3.12. Since this package is using dynamic versioning fromsetuptools_scmit should be loading its version from thesetuptools_scmgenerated file not viapkg_resources.This PR removes the use of
pkg_resourcesand instead loads version information from the file generated bysetuptools_scmas part of package install.