Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descr: Adding the Gold team's notebook: MAST Bulk Download through AWS. #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yli12313
Copy link

This is the Gold team's bulk download notebook that will undergo the formal notebook verification and publication process!

@ttdu
Copy link
Collaborator

ttdu commented Nov 19, 2024

To-dos:

  • Address PEP8 checks
  • Rename to bulk_downloads.ipynb (directory name and notebook name should match)
  • This is conceptually very similar to the large downloads notebook. It may be reasonable to combine them. Who requested this notebook / what are the requirements?
  • requirements should specify a version of astroquery, rather than astropy (I think this is causing the validation check to fail)
  • link updates: change the linked text "here" (this is bad for people who use screen readers). maybe add a few more links, e.g. to MAST
  • we should define what we mean by "bulk", and why people should prefer this method. are we just trying to lighten the load on MAST servers? do we anticipate a use-case where people pull all of the GALEX/PS1 data? for that matter, why do we call out those specific missions? HST almost certainly has more data (by GB) than GALEX, so why not focus on that?

@yli12313
Copy link
Author

@ttdu: Thank you for the feedback. It's good to know that there's another notebook that's similar and it's better to combine both notebooks. Some of the questions you posed are things we would need to address on the Gold team. We have never gone through the formal notebook validation and publication process before, and thought our notebook would be of value to the scientists. You make a lot of good points that we did not address, so I think we will start addressing each point either next sprint or the sprint after. Time is hard to come by right now given that B. Jordan on our team is on leave. But once things settle down, I will address everything such that we have a notebook that's actually useful. Thank you! - Y

@ttdu
Copy link
Collaborator

ttdu commented Nov 19, 2024

No worries -- we can take as long as needed for the review. Your notebook definitely has value to the scientists! I hope my comments did not convince you otherwise.

Happy to help if you have questions about the particulars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants