Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3737: Handle micrometeorite flashes #8894

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Draft

JP-3737: Handle micrometeorite flashes #8894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
091bcc6
Add flash code
drlaw1558 Oct 1, 2024
0f5eca7
Merge branch 'main' into jp-3737
drlaw1558 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions jwst/jump/jump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def run_detect_jumps(output_model, gain_model, readnoise_model,
minimum_sigclip_groups=100,
only_use_ints=True,
mask_snowball_persist_next_int=True,
snowball_time_masked_next_int=250
snowball_time_masked_next_int=250,
mmflashfrac = 1.0
):

# Runs `detect_jumps` in stcal
Expand Down Expand Up @@ -85,7 +86,8 @@ def run_detect_jumps(output_model, gain_model, readnoise_model,
minimum_sigclip_groups=minimum_sigclip_groups,
only_use_ints=only_use_ints,
mask_persist_grps_next_int = mask_snowball_persist_next_int,
persist_grps_flagged = snowball_grps_masked_next_int
persist_grps_flagged = snowball_grps_masked_next_int,
mmflashfrac = mmflashfrac
)


Expand Down
4 changes: 3 additions & 1 deletion jwst/jump/jump_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class JumpStep(Step):
minimum_groups = integer(default=3) # The minimum number of groups to perform jump detection using sigma clipping
minimum_sigclip_groups = integer(default=100) # The minimum number of groups to switch to sigma clipping
only_use_ints = boolean(default=True) # In sigclip only compare the same group across ints, if False compare all groups
mmflashfrac = float(default=1.0) # Fraction of array with jump to trigger flagging entire array as jump
"""

reference_file_types = ['gain', 'readnoise']
Expand Down Expand Up @@ -131,7 +132,8 @@ def process(self, step_input):
minimum_sigclip_groups=self.minimum_sigclip_groups,
only_use_ints=self.only_use_ints,
mask_snowball_persist_next_int=self.mask_snowball_core_next_int,
snowball_time_masked_next_int=self.snowball_time_masked_next_int
snowball_time_masked_next_int=self.snowball_time_masked_next_int,
mmflashfrac=self.mmflashfrac
)


Expand Down
Loading